[WIP] Add gRPC connection pooling for distributor->ingester connections. #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Tom Wilkie <[email protected]>
This is done inspired by a 'hack' in the bigtable client, where they use a resolver to return N copies of the same address. This is a little more generic. Hope is this will help combat some of the very high tail latencies we see for distributor pushes. Signed-off-by: Tom Wilkie <[email protected]>
Signed-off-by: Tom Wilkie <[email protected]>
Signed-off-by: Tom Wilkie <[email protected]>
tomwilkie
force-pushed
the
grpc-connection-pool
branch
from
55a6077 to
e4c4ba5
Compare
This is becuase we don't want to use it for the Bigtable client, and we don't want to override their existing hack. Signed-off-by: Tom Wilkie <[email protected]>
Contributor
Author
|
Having testing this, I've not seen a big improvement - and arguable no improvement at all. Will close, not worth the extra complexity. |
Contributor
|
Wondering if the bigtable idea relates to this issue: golang/go#27044 which is addressed in Go 1.12. gRPC connections are similar to, but not the same as, http/2 connections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done inspired by a 'hack' in the bigtable client, where they use a resolver to return N copies of the same address. This is a little more generic.
Hope is this will help combat some of the very high tail latencies we see for distributor pushes.
Signed-off-by: Tom Wilkie [email protected]